Skip to content

Conversation

danieldk
Copy link
Member

What does this PR do?

This is not safe until we have sandboxed builds. For TGI alone this might not be a huge issue, but with Cachix caching disabled in hf-nix, TGI CI would build all the packages and push it to our cache.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

drbh
drbh previously approved these changes Aug 25, 2025
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

danieldk and others added 2 commits August 26, 2025 12:03
This is not safe until we have sandboxed builds. For TGI alone
this might not be a huge issue, but with Cachix caching disabled
in hf-nix, TGI CI would build all the packages and push it to
our cache.
@drbh drbh force-pushed the disable-cachix-push branch from 9938a54 to ddb7dcb Compare August 26, 2025 16:03
@drbh
Copy link
Collaborator

drbh commented Aug 26, 2025

merging as these changes only contain a small CI change and the failing CI was introduced in prior changes

@drbh drbh merged commit 06d9d88 into main Aug 26, 2025
3 of 10 checks passed
@drbh drbh deleted the disable-cachix-push branch August 26, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants