Skip to content

Conversation

ShashStudios
Copy link

What does this PR do?

Fixes issue #40239: remove jieba dependenc and replace iwht wiht rjieba

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

cc @ydshieh

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 22, 2025

@ShashStudios

Thank you.

I think there are more to do in this PR, basically where jieba is used have to be changed, and check if the models using jieba are still working after the change.

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 30, 2025

Thank you @ShashStudios for opening this PR ❤️ . The issue is fixed in #40383 , so I'm going to close this PR.

@ydshieh ydshieh closed this Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants