Only use general purpose registers in c guest #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M registers for passing floats to rust functions that don't expect it Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
|
Are you still planning on merging this, @ludfjig ? |
Clang's docs state that this is an aarch64 only flag so probably not in this state at least. Unsure why this works at all tbh :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mismatch in the ffi ABI between c and rust. Rust library doesn't use SSE, so won't use XMM registers for passing floats as arguments, but clang will. This is a temporary fix until I figure out how to properly set this