-
-
Notifications
You must be signed in to change notification settings - Fork 1
Fix deep tests #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix deep tests #429
Conversation
Unit Tests Summary 1 files 15 suites 9s ⏱️ Results for commit ff62b01. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: ff62b01 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
- update snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome improvement on the helper.
It works and can be merged as is, but I found 2 small problems that don't hold off the merge, but it would be nice to address (especially the 1.
)
- A
set_inputs
that has no effect - Too many
# nolintr start
comments (see #431)- This can be reviewed later on
@@ -78,7 +79,7 @@ test_that("scatterplot module works as expected in the test app", { | |||
expect_identical(res, "GeneID:8086") | |||
|
|||
# Remove sample filter | |||
app$click("teal-teal_modules-scatterplot-filter_panel-filters-MAE-subjects-MAE_SEX-remove") | |||
app$click(ns_fp("MAE-subjects-MAE_SEX-remove")) | |||
app$wait_for_idle() | |||
|
|||
res <- app$get_value(input = ns("x_spec-genes")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install teal.slice as important fix has been merged recently (insightsengineering/teal.slice#663). Please remember to install teal.slice locally if you want to test this branch - shinytest2 is run in the separate session so every packages must be installed (load_all has no effect).
In this PR:
!!ns_fs(<input path>) := <input value>
. Thanks to this we just need to change "id" in one place if we ever change the namespace in teal or teal.slice