-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(ui): LoRA default weight #8484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): LoRA default weight #8484
Conversation
I wonder where to create the constant for LoRA |
Is it possible to extract the |
4a9f535
to
ad6b853
Compare
Sorry, I didn't see your questions in the PR until now!
Suggest to revert the Some context - we added parameter constraints to In hindsight, this ends up being tech debt, as the commercial app only overrides a few constraints. Having parameter constraints in
I don't think so as it's not a property of the LoRA model weights. We have some logic to extract parameters from LoRA metadata JSON sidecar files, but I don't think those specify weight. |
.../src/features/modelManagerV2/subpanels/ModelPanel/LoRAModelDefaultSettings/DefaultWeight.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Could small changes requested - great QoL improvement here.
6f94fac
to
04454cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
04454cd
to
63228a5
Compare
Summary
A new feature was implemented to specify LoRA default weight per model
LoraModelDefaultSettings
was created inconfig.py
to represent LoRA related default settingsdefault_settings
, was added toLoRAConfigBase
to persist LoRA related default settings in every kind of LoRA model instanceget_default_settings_lora
, was added tolegacy_probe.py
to populate default settings extracted from modelsLoraModelDefaultSettings
was added as another option toModelRecordChanges.default_settings
in order to persist LoRA related default settingsschema.ts
to make latest changes in backend API available in the frontendlora.weight
, was added to thezAppConfig
schema to store LoRA weight UI elements related default settingsselectLoRAWeightConfig
, was added toconfigSlice.ts
to retrieve LoRA weight UI elements related default settingsdefaultLoRAConfig
is created per request and was moved intoloraAdded
reducer to set LoRA weight based on default settingsuseLoRAModelDefaultSettings
custom hook was created to merge model and UI related default settingsDefaultWeight
component was created to represent and set the LoRA weight default settingLoRAModelDefaultSettings
component was created to manage LoRA default settingsLoRAModelDefaultSettings
component was added toModelView
to be able to separately manage main models and LoRA models default settingsLoRACard
componentlora.weight
, was added toen.json
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1408129778996740167
Checklist
What's New
copy (if doing a release after this PR)