feat(ui): add readiness checks for LoRAs #8506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Aug 29, 2025
If incompatible LoRAs are added, prevent Invoking. The logic to prevent adding incompatible LoRAs to graphs already existed. This does not fix any generation bugs; just a visual inconsistency where it looks like Invoke would use an incompatible LoRA.
psychedelicious
force-pushed
the
psyche/feat/ui/lora-readiness-checks
branch
from
0dcd23b to
1da6c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If incompatible LoRAs are added, prevent Invoking.
The logic to prevent adding incompatible LoRAs to graphs already existed. This does not fix any generation bugs; just a visual inconsistency where it looks like Invoke would use an incompatible LoRA.
I also slightly refactored how the readiness check args are passed in to use a single object. Much harder to accidentally pass the wrong thing in this way.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149506274971631688/1410666884306571396
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)