Typst Writer: Check XID_Continue in identifiers #11077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unicode-data dependency for isXIDContinue for this to match the rust implementation. Also apply hlint suggestions for redundant $, literal pattern and moving brackets to avoid $.
|
We already have a transitive dependency on unicode-data, so I think that's okay. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for
XID_Continuefor the identifiers in typst to match the rust implementation.Added
unicode-dataas a dependency for this for access to theisXIDContinuefunction to be able to easily check this. I hope this is an acceptable dependency addition in this case.Also applied the following types of hlint suggestions that came up:
Fixes: #10816