Latin unicode support #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jonschlinkert! |
|
@AntonioVdlC sorry, missed your pr somehow. I'll review today, thanks! |
fregante
reviewed
Sep 19, 2016
| nonWord: /[^A-Za-z0-9\u00C0-\u00D6\u00D8-\u00DD\u00DF-\u00F6\u00F8-\u00FF]/ | ||
| }; | ||
|
|
||
| var camelCase = new RegExp('(' + re.small.source + ')(' + re.capital.source + ')', 'g'); |
There was a problem hiding this comment.
Whoah never knew about RegExp#source 👍
|
What is the state of this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for Latin-1 Supplement Unicode characters (+ tests) and slightly modified the code to easily add new alphabets in the future.
I also noticed there was a
.eslintrc.jsonfile so I installedeslintas adevDependenciesand added the linting to thetestscript.Let me know if that works for you!