-
Notifications
You must be signed in to change notification settings - Fork 137
Reinstate Rails integration test stubs for Rails 5.0 -> 7.1 & 8.0 #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Use a defined methodology to generate the stubs to make it easier to support new versions.
14d67c7
to
2c6b6c9
Compare
…tub-tests # Conflicts: # src/spec/ruby/jruby/rack/integration_spec.rb
a379abc
to
e08d076
Compare
@chadlwilson My take - drop those Rails versions. Even Rails 6.0 is very EOL. Source: https://endoflife.date/rails |
@olleolleolle thanks for the opinion! Yeah, they are very EOL. I kept them earlier partly because Rails' support policy is quite aggressive, partly because this lib itself was dormant for many years and had issues on Rails 6 in some configurations (with java servlet session store) and to make it easier to reinstate these stub tests so the distance would be smaller between the last version that was actively integration tested here (rails 4.0). But that's largely moot now with this PR since it covers at least framework initialization through to Rails 8. The only thing that is vaguely of concern is that there are probably some jruby-rack features that are not working properly on modern rails/rack and may also benefit from being able to validate they work incrementally over Rails versions. For example, I think Having said that, the Rails 5 tests could live on for the 1.2.x branch for a while since they work fine there. |
Looks like
Open question
LoggerSilence
stuff doesn't work on Rails 5.0/5.2 as it doesn't exist there. Should we just drop testing these EOL versions or keep my small change here that makes it apply only to Rails 6.0 onwards?