-
-
Notifications
You must be signed in to change notification settings - Fork 75
Modify parsers to be AST-based #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
exports.foo are hoisted, but for improved readability.
96f666d
to
e75e388
Compare
PR ready. |
To run test against jsdom locally: cssstyle:
cd to jsdom and run:
Don't forget to run below against jsdom afterwards.
|
b7e65ec
to
98a06e3
Compare
I'll merge this, but what should we write in the changelog? It seems like a lot of properties were improved, and some new ones were added? Can we get a list of all of them? Or should we just give up and say "lots of parsing and serialization improvements to all properties"? |
No new properties are added. Summary of this PR:
|
Oh, this seems bad, since it's not in the spec. Can you export it from the module somewhere else instead of putting it on the (If we ever created wrappers using webidl2js per #235, then it wouldn't matter, but right now jsdom directly exposes cssstyle's |
It's fine with me to expose |
Uh oh!
There was an error while loading. Please reload this page.