Skip to content

Conversation

hungdinhxuan
Copy link

No description provided.

Copy link

welcome bot commented Nov 22, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@manics
Copy link
Member

manics commented Nov 22, 2023

Thanks for the PR! I think it'd be good to keep the basic example as simple as possible, but this would make a nice second example. Would you mind adding a new directory (you can probably just copy all the files from basic-example into that new directory), and add the directory to the test matrix?

strategy:
matrix:
example:
- basic-example

@hungdinhxstudent hungdinhxstudent force-pushed the main branch 2 times, most recently from 29c43b7 to 511bac6 Compare November 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants