Add meshgrid op support in Keras OpenVINO backend #21600
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @arunthakur009, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for the meshgrid operation within the Keras OpenVINO backend. Previously, this operation was not supported, leading to a NotImplementedError. The new implementation leverages OpenVINO operations to correctly compute meshgrid outputs, handling both "xy" and "ij" indexing conventions. This enhancement allows Keras models utilizing meshgrid to be compiled and executed efficiently with the OpenVINO backend.
Highlights
- Feature Implementation: Added a complete implementation for the
meshgridoperation in the Keras OpenVINO backend, replacing aNotImplementedError. - Test Integration: Enabled existing
meshgridtests for the OpenVINO backend by removing it from the list of excluded tests, confirming the new implementation's correctness. - OpenVINO Operations: The
meshgridimplementation utilizes core OpenVINO operations such asshape_of,constant,concat,reshape, andbroadcastto perform the necessary tensor manipulations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Summary of Changes
Hello @arunthakur009, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for the meshgrid operation within the Keras OpenVINO backend. Previously, this operation was not implemented, but now a full implementation is provided, allowing meshgrid to be used when leveraging OpenVINO for Keras computations. The implementation has been verified against existing tests, ensuring correctness and compatibility.
Highlights
meshgridImplementation: The meshgrid function has been fully implemented in the Keras OpenVINO backend, replacing the NotImplementedError.- OpenVINO Backend Integration: The implementation leverages OpenVINO operations like shape_of, constant, concat, reshape, and broadcast to correctly compute meshgrid outputs.
- Test Enablement: The NumpyOneInputOpsCorrectnessTest::test_meshgrid test case has been re-enabled by removing it from the excluded_concrete_tests.txt file, confirming the successful implementation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for the meshgrid operation in the Keras OpenVINO backend. The implementation correctly handles both 'xy' and 'ij' indexing. The corresponding test is also enabled by removing it from the exclusion list.
My review focuses on improving the code's readability and maintainability. I've suggested a refactoring of the logic for constructing the reshape shapes within the meshgrid function to make it simpler and easier to understand.
There was a problem hiding this comment.
Code Review
This pull request adds support for the meshgrid operation to the Keras OpenVINO backend, which is a great addition. The implementation is functionally correct and enables the corresponding tests.
My review focuses on improving the code's readability and maintainability. I've suggested refactoring a complex, nested conditional block into a more straightforward structure and removing a redundant check. These changes should make the code easier to understand and maintain in the future.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21600 +/- ##
==========================================
- Coverage 82.75% 82.45% -0.31%
==========================================
Files 567 572 +5
Lines 56722 57364 +642
Branches 8841 8977 +136
==========================================
+ Hits 46940 47298 +358
- Misses 7609 7764 +155
- Partials 2173 2302 +129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For code format issue |
arunthakur009
force-pushed
the
numpy.meshgrid
branch
from
b8fabb6 to
3774020
Compare
|
@Mohamed-Ashraf273 |
|
@shashaka Suggested Changes are implemented!! |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Description:
I have implemented the
meshgridoperation in theKeras OpenVINO backend.Verified the implementation by running the existingmeshgridtests innumpy_test.py,and all tests are passing with theOpenVINO backend.@rkazants Please take a look.
Ticket: openvinotoolkit/openvino#30116