-
Notifications
You must be signed in to change notification settings - Fork 426
frontend: Notifications: Fix contrast for menu items on all themes #3747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
frontend: Notifications: Fix contrast for menu items on all themes #3747
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vyncent-t The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
But now the buttons don't look disabled, they look like you can click on them which is misleading. |
50bfe8e
to
53dbccd
Compare
current contrast was too hard to read, tweaked the new contrast to still be faded and not solid, let me know if this is readable |
@@ -104,11 +104,31 @@ export default function NotificationList() { | |||
<Icon icon="mdi:dots-vertical" /> | |||
</IconButton> | |||
<Menu anchorEl={anchorEl} open={Boolean(anchorEl)} onClose={handleClose}> | |||
<MenuItem onClick={markAllAsRead} disabled={!hasUnseenNotifications}> | |||
<Typography color={'primary'}>{t('translation|Mark all as read')}</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that adjustment does work but only for the lights out contrast (it was blue before).
however for the dark mode contrast it is still the same contrast as the original issue #3746
Just to be clear I believe the main goal here is to make the disabled text pop a little bit more while still looking faded enough to not be mistaken as enabled. If the current colors are still too solid and do not fit disabled styles enough I can adjust it to be lighter. |
c154ebe
to
f71a85c
Compare
f71a85c
to
748559e
Compare
Summary
This PR fixes the issue where the text for notification menu items were not readable on darker themes
Related Issue
Related to issue #3746
Changes
Steps to Test
Screenshots (if applicable)
Before
After
disabled
enabled