Skip to content

Conversation

Moh0ps
Copy link

@Moh0ps Moh0ps commented Aug 20, 2025

Add Persian Translation For content/fa/docs/tutorials/cluster-management

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 20, 2025
@xirehat
Copy link
Contributor

xirehat commented Aug 22, 2025

/language fa

@k8s-ci-robot k8s-ci-robot added the language/fa Issues or PRs related to Persian language label Aug 22, 2025
@xirehat
Copy link
Contributor

xirehat commented Aug 22, 2025

@Moh0ps Rebase your branch with dev-1.33-fa.1 to bypass the build log error.

See these PRs: #51968 and #51927

@@ -0,0 +1,4 @@
---
title: "مدیریت خوشه"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "مدیریت خوشه"
title: "مدیریت کلاستر"

پس از دنبال کردن این آموزش، می‌توانید از خوشه ای که دارای {{< glossary_tooltip text="control plane" term_id="control-plane" >}} برای مدیریت پادها و گره‌ها و انواع دیگر اشیاء است، استفاده کنید. به عنوان مثال،
[Hello, minikube](/docs/tutorials/hello-minikube/)

همچنین می‌توانید kubelet را در حالت مستقل اجرا کنید تا برای موارد استفاده در محیط عملیاتی مناسب باشد، مانند اجرای صفحه کنترل برای یک خوشه با قابلیت دسترسی بالا و استقرار انعطاف‌پذیر. این آموزش جزئیات مورد نیاز برای اجرای یک صفحه کنترل انعطاف‌پذیر را پوشش نمی‌دهد
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
همچنین می‌توانید kubelet را در حالت مستقل اجرا کنید تا برای موارد استفاده در محیط عملیاتی مناسب باشد، مانند اجرای صفحه کنترل برای یک خوشه با قابلیت دسترسی بالا و استقرار انعطاف‌پذیر. این آموزش جزئیات مورد نیاز برای اجرای یک صفحه کنترل انعطاف‌پذیر را پوشش نمی‌دهد
همچنین می‌توانید kubelet را در حالت مستقل اجرا کنید تا برای موارد استفاده در محیط عملیاتی مناسب باشد، مانند اجرای کنترل پلین برای یک کلاستز با قابلیت دسترسی بالا و استقرار انعطاف‌پذیر. این آموزش جزئیات مورد نیاز برای اجرای یک صکنترل پلین انعطاف‌پذیر را پوشش نمی‌دهد

Copy link

@Behiuu Behiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review selected line

@Moh0ps Moh0ps force-pushed the persian-localization branch from 0eecb8a to a1515f5 Compare August 22, 2025 16:35
Copy link

netlify bot commented Aug 22, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c6859ac
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68b346ddb7e1c4000855e910
😎 Deploy Preview https://deploy-preview-51977--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Moh0ps Moh0ps force-pushed the persian-localization branch 2 times, most recently from bab56c4 to 7fd0bab Compare August 22, 2025 17:17
Copy link

@Behiuu Behiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Behiuu: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Moh0ps
Copy link
Author

Moh0ps commented Aug 23, 2025

@seokho-son The changes have been successfully built. When you get a chance, I’d really appreciate your review, and if everything looks good, kindly consider adding a /lgtm.❤️

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if the Persian part is good; I can only point out problems with the sections I can easily read. Sorry that this makes it a correction-only review.

```

```shell
kubectl get pods -l app=cattle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit)

Suggested change
kubectl get pods -l app=cattle
kubectl get pod -l app=cattle

Why? Because Persian speakers shouldn't have to learn English pluralization.


```shell
kubectl get deployment
kubectl get pods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit)

Suggested change
kubectl get pods
kubectl get pod

Why? Because Persian speakers shouldn't have to learn English pluralization.

@Moh0ps Moh0ps force-pushed the persian-localization branch 2 times, most recently from 3f23399 to 872e82b Compare August 25, 2025 18:48
@Moh0ps
Copy link
Author

Moh0ps commented Aug 25, 2025

(nit)

Why? Because Persian speakers shouldn't have to learn English pluralization.

First of all, I’d like to sincerely thank you @lmktfy for taking the time to review.
In my opinion, this is a command, if it were part of a normal sentence, I would definitely have translated it. But since it is a command, I didn’t make any changes to the commands and only translated the comments in the YAML files and scripts.
Additionally, both commands, i mean kubectl get pod and kubectl get pods will produce exactly the same result. I think it’s fine, and if you agree, I’d like to leave it as it is.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 30, 2025
@Moh0ps Moh0ps closed this Aug 30, 2025
@Moh0ps Moh0ps force-pushed the persian-localization branch from 4209845 to 7699f81 Compare August 30, 2025 17:59
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 30, 2025
@Moh0ps Moh0ps reopened this Aug 30, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2025
@seokho-son
Copy link
Member

It looks like @Moh0ps has addressed @lmktfy’s review well.
Regarding the example commands, I agree with @Moh0ps’s opinion to keep them as they are in the original.

That said, it would still be good to get a final confirmation from @lmktfy, since he initially raised the point. If the response is delayed, considering that @lmktfy mentioned it as a nit, I’ll guide us to move forward as is.

FYI, I also checked the preview results below, and they look good:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c1b5b07432e34b1fba6f05f5a5aa252d6870f2a9

Copy link
Contributor

@natalisucks natalisucks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5e454bb into kubernetes:dev-1.33-fa.1 Aug 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fa Issues or PRs related to Persian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants