Skip to content

Update legacy kubelet configmap name and modify typo in kubeadm-certs.md #52012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update legacy kubelet configmap name and modify typo in kubeadm-certs.md #52012

wants to merge 3 commits into from
+4 −4

Conversation

y-sera
Copy link
Contributor

@y-sera y-sera commented Aug 24, 2025

Description

In /en/docs/tasks/administer-cluster/kubeadm/kubeadm-certs.md,
update kubelet configmap name, and modify some typos.

Kubelet coonfigmap:
The name Configmap for kubelet in kube-system is renamed since v1.24 from kubelet-config-{{< skew currentVersion >}} to kubelet-config.

Other modify:

  • modify 3 unclosed parenthesis.
  • add anchor link of set-up-a-singer.

Issue

Closes: #52004

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 24, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f909768
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68b8581fb16b54000736c26e
😎 Deploy Preview https://deploy-preview-52012--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lmktfy
lmktfy reviewed Aug 25, 2025
View reviewed changes
lmktfy
lmktfy reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from an important mistake.

neolit123
neolit123 reviewed Aug 25, 2025
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Aug 25, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4583eeba56552cfc0790a96fd9acc04c5f439f20

Okabe-Junya
Okabe-Junya reviewed Aug 25, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

/lgtm
/assign lmktfy
for approval

@pacoxu
Copy link
Member

pacoxu commented Aug 26, 2025

/lgtm

singh1203
singh1203 approved these changes Aug 29, 2025
View reviewed changes
Copy link

@singh1203 singh1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@singh1203: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: singh1203
Once this PR has been reviewed and has the lgtm label, please ask for approval from lmktfy. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

t-inu
t-inu reviewed Sep 2, 2025
View reviewed changes
@y-sera @t-inu
delete anchor set automatically '#set-up-a-signer'
f909768 
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2025
Okabe-Junya
Okabe-Junya reviewed Sep 3, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b670873e031b5b6ebcee03f1cf603410cefc391

t-inu
t-inu reviewed Sep 5, 2025
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-inu t-inu t-inu left review comments

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@salaxander salaxander Awaiting requested review from salaxander

@lmktfy lmktfy Awaiting requested review from lmktfy

@neolit123 neolit123 Awaiting requested review from neolit123

@pacoxu pacoxu Awaiting requested review from pacoxu

+1 more reviewer

@singh1203 singh1203 singh1203 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@neolit123 neolit123

@pacoxu pacoxu

@t-inu t-inu

@Okabe-Junya Okabe-Junya

@lmktfy lmktfy

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm-certs.md has typo and remains legacy configmap name for kubelet
8 participants
@y-sera @k8s-ci-robot @pacoxu @neolit123 @singh1203 @t-inu @Okabe-Junya @lmktfy