-
Notifications
You must be signed in to change notification settings - Fork 19k
fix(core): propagate RunnableConfig
to tools in AgentExecutor
(sync/async); support Optional/Union signatures
#32768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(core): propagate RunnableConfig
to tools in AgentExecutor
(sync/async); support Optional/Union signatures
#32768
Conversation
…tional/union typing coverage\n test(core): add JSON schema dereference recursion guards\n chore(scripts): move manual validation under scripts/manual and remove root-level copies
…(sync/async); support Optional/Union signatures; mypy and lint clean
The latest updates on your projects. Learn more about Vercel for GitHub. |
CodSpeed WallTime Performance ReportMerging #32768 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32768 will not alter performanceComparing Summary
|
… organize imports to satisfy Ruff
…on optional tests
RunnableConfig
to tools in AgentExecutor
(sync/async); support Optional/Union signatures
Issue
Fixes #32671
Summary
AgentExecutor
propagatesRunnableConfig
to tools in both sync (invoke
/_call
) and async (ainvoke
/_acall
) paths.Optional[RunnableConfig]
orUnion[RunnableConfig, None]
in their signatures.return_direct
behavior, async handling withasyncio_timeout
, and trimming of intermediate steps.Implementation notes
AgentExecutor
sets/restores a private current config aroundinvoke
/ainvoke
using a module-level sentinel and restores it safely (mypy clean).getattr(self, "_current_config", None)
and are invoked with it when present.yaml
import marked untyped to satisfy mypy; can switch totypes-PyYAML
if preferred.Tests
Optional[RunnableConfig]
andUnion[RunnableConfig, None]
in sync and async tool paths.return_direct
, async timeout behavior, and intermediate step trimming.Checklist