[12.x] Add supports for SQS Fair Queue #56763
Merged
+71
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
src/Illuminate/Queue/SqsQueue.php
Outdated
|
|
||
| $messageGroupId = transform($job->messageGroup ?? null, fn ($messageGroup) => strval($messageGroup)); | ||
|
|
||
| $messageDeduplicationId = $job instanceof ShouldBeUnique && method_exists($job, 'uniqueId') |
There was a problem hiding this comment.
I'm a bit worried about this one... people may not expect ShouldBeUnique to have the effect this would cause.
AWS will not accept another job with the same de-dup ID for 5 minutes, even if there are no other jobs on the queue with that ID.
There was a problem hiding this comment.
Swap to check for deduplicateId() method instead.
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant codes: