-
Notifications
You must be signed in to change notification settings - Fork 298
Variational Smoothing for Pyramids #4232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The factor 1.05 was changed to 1.03 because it was triggering false assertions on `distortion_is(*node, true)` due to the 2*4 scale factor. The tolerance on the volume comparison was loosened from the default (TOLERANCE^2) to TOLERANCE because the former was too tight. Ref libMesh#4082.
…lar sides, hard-coded unit test checks for base-apex and triangular face midpoint nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel like there's some sort of Clue we're missing, something suboptimal about the variational scheme, that would suggest why our "minimally distorted" higher-order pyramids are still getting distorted in an unexpected way, but for now I'm content to put that up on the "pyramids kinda suck" shelf and add what support we can for them.
From the failing min clang recipe:
Funny, it converges on my machine :) |
The "Test MOOSE" (inc. clang) issues are downstream and unrelated. The prior "Test with threads" timeouts still worry me. Getting through unit tests in CI opt mode should take like 20 minutes tops; we shouldn't be coming anywhere near a 60 minute timeout. Cutting the mesh sizes from 4^n to 2^n in the case of higher order elements gets us down to 26.5 minutes, which seems fine, but I may kick that a few times before we merge just to see what the variation is. |
Added support to the
VariationalMeshSmoother
for pyramids.Ref. #4082