Skip to content

Conversation

pbehne
Copy link
Contributor

@pbehne pbehne commented Aug 21, 2025

Added support to the VariationalMeshSmoother for pyramids.

Ref. #4082

pbehne added 4 commits August 21, 2025 15:27
The factor 1.05 was changed to 1.03 because it was triggering false
assertions on `distortion_is(*node, true)` due to the 2*4 scale factor.

The tolerance on the volume comparison was loosened from the default
(TOLERANCE^2) to TOLERANCE because the former was too tight.

Ref libMesh#4082.
…lar sides, hard-coded unit test checks for base-apex and triangular face midpoint nodes.
Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel like there's some sort of Clue we're missing, something suboptimal about the variational scheme, that would suggest why our "minimally distorted" higher-order pyramids are still getting distorted in an unexpected way, but for now I'm content to put that up on the "pyramids kinda suck" shelf and add what support we can for them.

@pbehne
Copy link
Contributor Author

pbehne commented Aug 27, 2025

From the failing min clang recipe:

1) test: MeshSmootherTest::testVariationalHex27Tangled (E) 
uncaught exception of type std::exception (or derived).
- Unrecoverable failure to converge

Funny, it converges on my machine :)

@moosebuild
Copy link

Job Coverage, step Generate coverage on 290bfcc wanted to post the following:

Coverage

82cc40 #4232 290bfc
Total Total +/- New
Rate 64.57% 64.72% +0.14% 96.97%
Hits 75998 76189 +191 32
Misses 41693 41534 -159 1

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr
Copy link
Member

The "Test MOOSE" (inc. clang) issues are downstream and unrelated.

The prior "Test with threads" timeouts still worry me. Getting through unit tests in CI opt mode should take like 20 minutes tops; we shouldn't be coming anywhere near a 60 minute timeout. Cutting the mesh sizes from 4^n to 2^n in the case of higher order elements gets us down to 26.5 minutes, which seems fine, but I may kick that a few times before we merge just to see what the variation is.

@roystgnr roystgnr merged commit 9ce5636 into libMesh:devel Aug 28, 2025
18 of 20 checks passed
@roystgnr roystgnr deleted the variational_smoother_pyramid branch August 28, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants