Process(windows): try sending WM_CLOSE for graceful process termination #13108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the QT method of sending WM_CLOSE to all application window, then send WM_CLOSE to the main thread of the child process.
Description
Windows always makes things more complicated.
On Windows, there are multiple ways to gracefully terminate a process.
GenerateConsoleCtrlEvent.None of these two ways cover all applications - WM_CLOSE only works when the program has a message loop like in GUI programs,
GenerateConsoleCtrlEventhas quirks.Existing Issue(s)