Add some missing and features from the presentation namespace
#318
+1,274
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joseph-Edwards
requested changes
Aug 26, 2025
There was a problem hiding this comment.
This looks good to me, other than some minor doc issues highlighted below. I will also add try_detect_inverses when libsemigroups/libsemigroups#785 is merged.
Thanks @james-d-mitchell!
| :rtype: | ||
| datetime.datetime | ||
| datetime.timedelta |
There was a problem hiding this comment.
I think this was correct originally
There was a problem hiding this comment.
So, the reason I did this is that there was a warning that the return type didn't match the value from the signature when running make doc
| :rtype: | ||
| datetime.datetime | ||
| datetime.timedelta |
There was a problem hiding this comment.
I think this was correct originally.
There was a problem hiding this comment.
Same comment as above
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.