-
Notifications
You must be signed in to change notification settings - Fork 91
WIP: CI Tests using docker image #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docker stop llmster || true | ||
docker rm llmster || true | ||
|
||
# Coverage check for Docker tests (higher target since they include LM Studio tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one Python version per-platform actually collects coverage data, so if we're not combining across platforms, there's no need for the coverage analysis to be a separate job.
I'm not sure of the rationale for skipping the combined coverage report, though. Checking the per-platform coverage in addition to the combined coverage does seem reasonable.
@rugvedS07 One of your remaining failures is an existing test ordering issue: the intended usage of
Probably the simplest interim fix is to pre-download (but not load) The other failure I saw is due to one of the plugin test cases not seeing the expected graceful shutdown message. It's plausible that one is just outright flaky and/or distro sensitive (it's previously only been tested by me locally in Fedora WSL and Windows Powershell) |
I just added Python 3.14 to the CI test matrix in main, so that's the origin of the reported merge conflict. |
Overview
Adds the ability to run full tests in CI for linux using the docker container.
Fixes #140 for linux tests