Skip to content

Conversation

mcansh
Copy link
Owner

@mcansh mcansh commented Aug 12, 2025

No description provided.

mcansh added 29 commits June 9, 2022 20:38
this is based on https://github.com/remarkjs/remark-reference-links and https://github.com/remarkjs/remark-defsplit in that it converts inline links to a definition list, but unlike https://github.com/remarkjs/remark-defsplit it puts them all at the bottom

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
…ppend numeric if there's a dupe

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
… a link

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
* chore(deps): bump to latest, add prettier-plugin-organize-imports

Signed-off-by: GitHub <noreply@github.com>

* chore: run prettier

Signed-off-by: GitHub <noreply@github.com>

* test: update assertions

Signed-off-by: GitHub <noreply@github.com>

* test: update workflows

Signed-off-by: GitHub <noreply@github.com>

* chore: add .node-version file with version 22

Signed-off-by: GitHub <noreply@github.com>

* chore: add packageManager field to package.json

Signed-off-by: GitHub <noreply@github.com>

* chore: update tsconfig.json schema and compiler options

Signed-off-by: GitHub <noreply@github.com>

* feat: build with tsdown

Signed-off-by: GitHub <noreply@github.com>

* chore: update tsconfig

Signed-off-by: GitHub <noreply@github.com>

* chore: remove glob in favor of built in

Signed-off-by: GitHub <noreply@github.com>

* feat: rewrite the library

Signed-off-by: GitHub <noreply@github.com>

* chore: move fixtures directory to root level, move test file to src directory

Signed-off-by: GitHub <noreply@github.com>

* fix: adjust path separators in test assertions for cross-platform compatibility

Signed-off-by: GitHub <noreply@github.com>

* feat: add artifact upload for failed tests in CI workflow

Signed-off-by: GitHub <noreply@github.com>

* ci

Signed-off-by: GitHub <noreply@github.com>

* feat: update test workflow to upload failed fixtures and improve test setup

Signed-off-by: GitHub <noreply@github.com>

* x

Signed-off-by: GitHub <noreply@github.com>

* x

Signed-off-by: GitHub <noreply@github.com>

* test: add windows processed files

Signed-off-by: GitHub <noreply@github.com>

* chore: remove shit

Signed-off-by: GitHub <noreply@github.com>

* test: pls forgive me for i have lost all sense of humanity

Signed-off-by: GitHub <noreply@github.com>

* x

Signed-off-by: GitHub <noreply@github.com>

* x

Signed-off-by: GitHub <noreply@github.com>

* y

Signed-off-by: GitHub <noreply@github.com>

* z

Signed-off-by: GitHub <noreply@github.com>

* test: normalize line endings

Signed-off-by: GitHub <noreply@github.com>
…efinition-links

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Copy link

changeset-bot bot commented Aug 12, 2025

⚠️ No Changeset found

Latest commit: 246d7db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
218 1 217 0
View the top 1 failed test(s) by shortest run time
packages/remark-definition-links/run.test.js > run.test.js
Stack Traces | 0s run time
Error: Cannot find module './dist/index.js' imported from 'D:.../packages/remark-definition-links/run.js'
 ❯ run.js:10:1

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'ERR_MODULE_NOT_FOUND' }
Caused by: Caused by: Error: Failed to load url ./dist/index.js (resolved id: ./dist/index.js) in D:.../packages/remark-definition-links/run.js. Does the file exist?
 ❯ loadAndTransform ../../node_modules/.pnpm/vite@6.3.5_@types+node@24..../node/chunks/dep-DBxKXgDP.js:35725:17

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mcansh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on integrating and testing a new remark plugin, remark-definition-links, into the project. This plugin is designed to convert inline links in Markdown to a definition list, placing them at the bottom of the document. The extensive addition of Markdown files under packages/remark-definition-links/fixtures/ serves as comprehensive test cases and documentation examples for the new plugin's functionality, covering various aspects of Remix API, guides, and pages. Minor adjustments to project configuration files (package.json and .prettierignore) support the inclusion and proper handling of this new package.

Highlights

  • New Remark Plugin Integration: A new remark plugin, remark-definition-links, has been integrated. This plugin automatically converts inline Markdown links into a neatly organized definition list at the bottom of the document, improving readability and document structure.
  • Comprehensive Fixture and Documentation Additions: An extensive collection of Markdown files has been added under packages/remark-definition-links/fixtures/. These files serve as comprehensive test cases and detailed documentation examples, showcasing the new plugin's functionality across various Remix documentation sections, including API references, guides, and general pages.
  • Project Configuration Updates: Minor configuration adjustments were made across the project's package.json files and .prettierignore. These updates ensure proper build processes, dependency management, and code formatting for the newly introduced remark-definition-links package and its associated fixture files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
packages 246d7db Commit Preview URL

Branch Preview URL
Aug 20 2025, 09:38 PM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new package, @mcansh/remark-definition-links, which is a remark plugin designed to convert inline links into definition links. The PR also includes extensive test fixtures for this new package. Other changes primarily involve reformatting package.json files due to an update in the Prettier plugin for sorting JSON. While the new package is a great addition, I've found a critical issue in its core logic that needs to be addressed.

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Copy link

pkg-pr-new bot commented Aug 12, 2025

More templates

npm i https://pkg.pr.new/mcansh/packages/@mcansh/http-helmet@72
npm i https://pkg.pr.new/mcansh/packages/@mcansh/remark-definition-links@72
npm i https://pkg.pr.new/mcansh/packages/@mcansh/url@72
npm i https://pkg.pr.new/mcansh/packages/@mcansh/vitest-response-matchers@72

commit: 246d7db

mcansh added 8 commits August 12, 2025 20:04
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: GitHub <noreply@github.com>
…with no alt text

Signed-off-by: GitHub <noreply@github.com>
…essary settings

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant