Skip to content

Conversation

kanekosh
Copy link
Contributor

Purpose

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray
Copy link
Member

A-CGray commented Aug 27, 2025

Any idea what's going on with the failing tests @kanekosh ? Seems to be related to the version of OpenMDAO as it doesn't occur on the stable images

@kanekosh
Copy link
Contributor Author

kanekosh commented Sep 8, 2025

Any idea what's going on with the failing tests @kanekosh ? Seems to be related to the version of OpenMDAO as it doesn't occur on the stable images

@sabakhshi one of the multi-section tests (test_multi_single.py) is failing with OM 3.40 but I don't know why. Could you give it a look?

This failing test is separate from the ruff fixes here (I reproduced the test failure on the main branch too), so we should fix the test in a separate PR and meanwhile we can override and merge this PR.

@kanekosh kanekosh marked this pull request as ready for review September 8, 2025 15:19
@kanekosh kanekosh requested a review from a team as a code owner September 8, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants