-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
ContactSyncService: Implement related functions #2733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@DaVinci9196 so can people api not be made to work with MicroG? This is critical, as since a few weeks ago all requests made to the old apis return: This includes the google contacts sync adapter |
@DaVinci9196 I would like to help to finish implementing this. Please respond. |
Sorry, I just noticed today that I used OauthToken generated based on GMS and Google Contacts app when verifying whether PeopleApi is available. Unfortunately, errors such as unable to access the API and no contacts permission appeared. You can try to see if there are other ways to solve these errors. |
I am looking into this |
I am still looking into this, as the entire structure of the api has changed this is not as simple as I thought. |
@Sense101 sorry for bothering, but what have you discovered? |
No problem, took a break from this although I will be returning to it. Part of what I was working on is that the format of the .proto files (which define data sent between the client and server) must include specific annotations to link up correctly with the new google api's. This required different dependencies to the ones used right now in MicroG, which was a whole mess to sort out. Still lots of work to do, but that's part of what I discovered :) |
Just noting I had some incorrect assumptions about this. |
@DaVinci9196 I have been working on this, and have replicated calling the People api using an oauth generated based on GMS. I got the following error messsage back from google:
Was this the same error that you saw? If not, what error did you see? I tried generating oauth token based on the old contacts sync adapter id but couldn't get an auth token. I think this is a crucial feature for microg to have so it should be a priority to fix. The only next step I see from here is reverse engineering how play services does it, which I have no experience with. If anyone else is willing to help with this it would also be appreciated. |
@Sense101 Yes, we have encountered this problem since the beginning. This is a configuration behavior of GMS itself and there is no way to bypass or fix it. The current solution was adopted as the last resort to sync contacts. |
@DaVinci9196 so to clarify, you're saying there is no way to now include contacts sync within MicroG? |
@Sense101 At least not yet, maybe Marvin is considering other options. |
Before implementing the contact sync part have you tried to implement the backup transport part? On Android 4.4 (Kitkat) the Google Contact Sync Adapter behave in this way:
Before Android 6 (Marshmallow) all Google Backup Transports include the service: On Android 7.1.2 (Nougat) Google Contact Sync Adapter say this:
So if we implement the missing parts in microG Services (possibly service |
Includes:
Note:
Tried to use PeopleApi, but did not have access to the interface.