refactor: consolidate AI Foundry AVM + custom code #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter clarity and maintainability
- Simplified the output structure in `ai-project.bicep` by directly outputting project name, resource ID, and API endpoint instead of using a separate output type. - Deleted the `ai-services.bicep`, `dependencies.bicep`, and `keyVaultExport.bicep` modules as they are no longer needed. - Introduced a new module `ai-services-model-deployments.bicep` to handle cognitive services account deployments and role assignments. - Updated role assignment handling to utilize built-in role names for better clarity and maintainability.
… update references
…D for clarity and update related references
alguadam
changed the title
alguadam
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Prajwal-Microsoft,
marktayl1,
Fr4nc3,
Vinay-Microsoft and
aniaroramsft
as code owners
… clarify AI Project resource ID
…le existing project condition
…ndencies in aiServicesName assignment
…nment by removing conditional check
… subscription ID assignment for existing AI projects
…existingAiFoundryAiProjectResourceId
Roopan-Microsoft
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This Pull Requests aims to enhance the improvements of #391 by handling management of AI Foundry resources through latest version of AVM module plus child modules (
ai-project.bicepandai-services-deployments.bicep) that handle the additional code neededDoes this introduce a breaking change?
How to Test
What to Check
Verify that the code deploys:
Other Information