Skip to content

mcp: remove references to ClientRequest[T] for concrete T #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

mcp: remove references to ClientRequest[T] for concrete T #343

merged 1 commit into from
Aug 21, 2025

Conversation

jba
Copy link
Contributor

@jba jba commented Aug 21, 2025

See related PR about ServerRequest[T].

@jba
mcp: remove references to ClientRequest[T] for concrete T
0df0492 
See related PR about ServerRequest[T].
@jba jba requested review from findleyr and samthanawalla August 21, 2025 16:39
findleyr
findleyr approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@findleyr findleyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. What if we stop here, and just leave the helper aliases?

If we're not going to embed *ServerRequest, etc, there really no reason not to just use an alias.

@jba jba merged commit bf79d78 into modelcontextprotocol:main Aug 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samthanawalla samthanawalla samthanawalla approved these changes

@findleyr findleyr findleyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jba @samthanawalla @findleyr