Skip to content

tailwindcss-animate should be a dev dependency #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

phuctm97
Copy link

@phuctm97 phuctm97 commented Aug 12, 2025

  • Moved tailwindcss-animate to devDependencies in client package.json
  • Regenerated package-lock.json with latest dependency versions

Updated client dependencies to ensure compatibility with latest versions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@phuctm97 phuctm97 changed the title Update client dependencies tailwindcss-animate should be a dev dependency Aug 12, 2025
@@ -72,6 +71,7 @@
"jest-environment-jsdom": "^29.7.0",
"postcss": "^8.5.6",
"tailwindcss": "^3.4.13",
"tailwindcss-animate": "^1.0.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looking at the build, it looks like this might be used in the build process - how did you determine that it only needs to be in devDependencies? This branch seems to build locally for me, but haven't checked yet to see if it might be needed for CICD.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting tailwindcss-animate in dependencies means that any package that uses the published @modelcontextprotocol/inspector npm package must also install tailwindcss-animate and all of its dependencies.

The published @modelcontextprotocol/inspector npm package contains only already-built code. All dependencies that are used to build/produce the final @modelcontextprotocol/inspector package content doesn't need to be installed in downstream projects to be able to use @modelcontextprotocol/inspector package.

Put simply, any packages that are only used to build a package should be a devDependency and not a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants