feat: Introduce Slf4jLoggingConsumer #503
Open
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
MCP Client-side consumer which logs received messages from MCP Servers using SLF4J.
How Has This Been Tested?
Yeah, it seems to work.
Breaking Changes
Will users need to update their code or configurations? No, this is non-breaking. It's just a new class which can be used with
SyncSpec#loggingConsumer(Consumer)to log received MCP messages. But if a user upgrades without using it, then there will no change.Types of changes
Checklist
Additional context
This class originated in (my) here, where it is used for https://docs.enola.dev/concepts/mcp/.
It then found its way into Google's Agent Development Kit (ADK) in google/adk-java#370.
I'm now proposing to "upstream" it here to be useful to others.