Add missing title, size and annotation attributes on Resource/ResourceTemplate and other types #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Annotations
typeResource.title
,Resource.size
andResource.annotations
ResourceTemplate.title
andResourceTemplate.annotations
TextContent.annotations
ImageContent.annotations
AudioContent.annotations
EmeddedResource.annotations
Fixes #159.
(PS: the solution I described in the issue was wrong. I checked with the specification's schema to be sure of the changes.)
Motivation and Context
Adherence to the latest specification version, cf. #159.
How Has This Been Tested?
I only added a serialization/deserialization test for
Annotations
to ensure that the serializer forkotlin.time.Instant
was indeed present. Cf. below in "Additional Context".Breaking Changes
N/A
Types of changes
Checklist
Additional context
I took two liberties:
Annotations.lastModified
, as this must be encoded as an ISO 8601 date.Annotations.priority
to verify that it is between 0 and 1.