Skip to content

Remove dependency on CIO engine #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MukjepScarlet
Copy link

@MukjepScarlet MukjepScarlet commented Aug 13, 2025

Replace the CIO dependency with only server/client core dependency.

Motivation and Context

In order to minimize the size of package. There are probably other existing engines like Netty/Tomcat(server) or Java/OkHttp/Apache(client) in the classpath. So we can reuse existing infrastructure.

How Has This Been Tested?

I have run:

  • kotlin-sdk-client: jvmTest, jsTest
  • kotlin-sdk-test: jvmTest, jsTest
  • kotlin-sdk-server: allTests
  • All build of samples

I have an issue about samples/kotlin-mcp-server. io.modelcontextprotocol is not found in commonMain.

Breaking Changes

Yes. They need to implementation CIO engine manually if they use it in their app.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

closes #111

@devcrocod
Copy link
Contributor

Thanks @MukjepScarlet for your pr!

Sorry, I’m having trouble understanding the motivation behind this PR
Is the package size really so large that it needs to be reduced, especially considering that the user will still need a dependency on some engine anyway?

Also, the user can already choose any other engine. CIO is just the default engine

@MukjepScarlet
Copy link
Author

The main motivation is that the users of client applications like iOS/Android/Desktop would like to see a smaller package. And we usually want to integrate the lib into an existing application with some infrastructures, maybe tons of configurations, in this situation the lib-integrated engine is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support other engines (client/server)
2 participants