fix hang caused by StreamableHttpClientTransport (#226) #227
+52
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-throw exceptions in
StreamableHttpClientTransport
soProtocol
doesn't hang indefinitely.Motivation and Context
Fixes the issue described in #226
How Has This Been Tested?
I've verified that my test case reproduces the error without my fix, and verified with breakpoints that the hang occurred where I described it.
Breaking Changes
None
Types of changes
Checklist
Additional context
I am unsure about the dispatcher I used for the real-time timeout here. I could not get the test to work otherwise, as
kotlinx.coroutines.test
was always tripping my timeout, with or without the fix. This is seemingly unrelated to the test case though, as removing my timeout results in the timeout in Protocol being tripped, even though that's not the point of the indefinite hang.