feat: Add CORS configuration for browser-based MCP clients #1059
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Jul 4, 2025
Comment on lines
135
to
142
|
|
||
| # Add CORS middleware to expose Mcp-Session-Id header for browser-based clients | ||
| starlette_app.add_middleware( | ||
| CORSMiddleware, | ||
| allow_origins=["*"], # Allow all origins - adjust as needed for production | ||
| allow_methods=["GET", "POST", "DELETE"], # MCP streamable HTTP methods | ||
| expose_headers=["Mcp-Session-Id"], | ||
| ) |
There was a problem hiding this comment.
You need to wrap the whole application instead of using add_middleware, otherwise 500s don't get in this.
- Add CORSMiddleware to streamable HTTP example servers - Configure minimal CORS with Mcp-Session-Id exposed - Add CORS documentation section to README This enables browser-based clients to connect to MCP servers by properly exposing the Mcp-Session-Id header required for session management. Reported-by: Jerome
jerome3o-anthropic
force-pushed
the
jerome/cors-browser-support
branch
from
7a554e7 to
28aaa02
Compare
felixweinberger
requested review from
felixweinberger
and removed request for
felixweinberger
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
previously approved these changes
Jul 7, 2025
felixweinberger
previously requested changes
Jul 9, 2025
That's a flaky test. |
|
We still need to address comment in #1059 (comment) for examples, only readme was changed, right? |
- Change from add_middleware() to CORSMiddleware wrapper pattern - Ensures 500 errors get proper CORS headers for browser clients - Update both streamable HTTP example servers - Fix README documentation to show complete example Reported-by: Jerome
felixweinberger
previously approved these changes
Aug 21, 2025
felixweinberger
force-pushed
the
jerome/cors-browser-support
branch
from
1792336 to
bf7ab5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mcp-Session-IdheaderProblem
Browser-based MCP clients cannot access the
Mcp-Session-Idheader from initialization responses due to CORS restrictions. Without this header, they cannot establish sessions with MCP servers.Solution
This PR adds Starlette's
CORSMiddlewareto the example servers and configures it to expose theMcp-Session-Idheader viaexpose_headers. The configuration is minimal, only allowing the HTTP methods required by the MCP protocol (GET, POST, DELETE).Changes
CORSMiddlewareimport and configuration to:examples/servers/simple-streamablehttp/mcp_simple_streamablehttp/server.pyexamples/servers/simple-streamablehttp-stateless/mcp_simple_streamablehttp_stateless/server.pyTest plan
Mcp-Session-Idheader from responsesReported-by: Jerome