Skip to content

Add PATHEXT to default STDIO env vars in windows #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timesler
Copy link
Contributor

@timesler timesler commented Aug 9, 2025

Add PATHEXT to default env vars in windows

Motivation and Context

The PATHEXT env var is required for the subprocess to be able to find many executable and other files

How Has This Been Tested?

Tested before and after with a STDIO server that provides powershell tools. Only works with this change in place

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

The PATHEXT env var is required for the subprocess to be able to find many executable and other files
@timesler timesler marked this pull request as ready for review August 9, 2025 21:58
@timesler timesler requested a review from a team as a code owner August 9, 2025 21:58
@timesler timesler requested a review from Kludex August 9, 2025 21:58
@timesler timesler changed the title Add PATHEXT to default env vars in windows Add PATHEXT to default STDIO env vars in windows Aug 9, 2025
Copy link

@ochafik ochafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @timesler, thanks for sending this!

Looks straightforward / goes hand in hand w/ PATH on windows.

@ochafik ochafik merged commit 9a8592e into modelcontextprotocol:main Aug 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants