-
Notifications
You must be signed in to change notification settings - Fork 2.3k
SDK Parity: Avoid Parsing Server Response for non-JsonRPCMessage Requests #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justin-yi-wang
wants to merge
11
commits into
modelcontextprotocol:main
Choose a base branch
from
justin-yi-wang:no-responses-for-notifs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SDK Parity: Avoid Parsing Server Response for non-JsonRPCMessage Requests #1290
justin-yi-wang
wants to merge
11
commits into
modelcontextprotocol:main
from
justin-yi-wang:no-responses-for-notifs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
requested changes
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @justin-yi-wang!
ochafik
requested changes
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, two last nits!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieve parity with the TypeScript SDK by only parsing server responses to JsonRPCRequests.
Motivation and Context
In the TypeScript SDK, server responses are only parsed if the request is a JsonRPCRequest (ie. has "method" and "id" fields) - link. Otherwise, the response is ignored. Here in the Python SDK, all responses are parsed. Concretely, we've seen in the wild that servers may try to respond to notifications with a 204 No content rather than a 202 Accepted (which is special cased in both SDKs), resulting in a Pydantic validation error. Subsequently, server developers are confused why their servers work with clients presumably using the TypeScript SDK, but not ones using the Python SDK.
How Has This Been Tested?
This PR includes a test.
Breaking Changes
No. Per the MCP protocol, the server should not respond to notifications.
Types of changes
Checklist
Additional context