-
Notifications
You must be signed in to change notification settings - Fork 204
Fix struct duplication between internal/model and tools/publisher #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@domdomegg - It's alright, no worries 🍻 I'll make sure to address your feedback and rebase it 👍 |
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
56d1a0d
to
fefb5ca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
fefb5ca
to
a0123ba
Compare
@domdomegg - hey, I don't have the rights to mark the PR out of draft and edit the PR description so I'll place it as a comment here - Motivation and Context• Remove duplicated structs in What’s changed• Switched publisher to import Example output{
"name": "io.github.example/simple-server",
"description": "A simple MCP server",
"status": "active",
"repository": {
"url": "https://github.com/example/simple-server",
"source": "github",
"id": ""
},
"version_detail": {
"version": "1.0.0"
},
"packages": [
{
"registry_name": "npm",
"name": "io.github.example/simple-server",
"version": "1.0.0",
"runtime_hint": "npx"
}
]
} How Has This Been Tested?• Built the publisher and generated a sample server.json; verified unset fields are omitted where omitempty is present. Breaking Changes• None. Types of changes• Refactor / code hygiene. Related• Add omitempty to repository.id or introduce a minimal DTO for publisher output to prevent accidental inclusion of registry-managed fields (already addressed via #285) |
Regarding this #217 (review) comment - I assume now that we have the |
Yep I think this is correct! I think also because of the extensions spec that we've agreed on the model can be exactly the same between publisher and registry :) |
I sincerely apologize for the disruption. This PR was accidentally closed due to an unintended git history rewrite operation that broke the connection between branches. The operation has been reverted and I'm now recreating the affected PRs.\n\nOriginal PR: #217