Skip to content

[test] minites-reporters do not work with RubyMine #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

honzasterba
Copy link
Contributor

Disable Minitest::Reporters when running tests in RubyMine

Motivation and Context

I want to execute tests directly in ruby mine and Minitest::Reporters is not compatible with RubyMine test runner

How Has This Been Tested?

Locally running tests in and outside of RubyMine

Breaking Changes

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Dev tools support

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@honzasterba honzasterba force-pushed the rubymine_test_runner_support branch from aa9f982 to b3c0b66 Compare August 20, 2025 09:13
@honzasterba honzasterba changed the title [test] only load reporters when outside of rubymine test runner [test] minites-reporters do not work with RubyMine Aug 20, 2025
@honzasterba honzasterba force-pushed the rubymine_test_runner_support branch from b3c0b66 to 6a1948c Compare August 20, 2025 09:17
gem not compatible with rubymine test runner
@honzasterba honzasterba force-pushed the rubymine_test_runner_support branch from 6a1948c to 1895168 Compare August 20, 2025 09:17
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, since I'm not sure about the background of its introduction, I will leave the decision to @atesgoral or @topherbullock.

@topherbullock
Copy link
Contributor

Looks good to me. However, since I'm not sure about the background of its introduction, I will leave the decision to @atesgoral or @topherbullock.

LGTM; this made sense when this was an internal gem running in Shopify's build system, but no longer!

@topherbullock topherbullock merged commit 06bf90d into modelcontextprotocol:main Aug 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants