Fix race condition between transport start and initialization #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-ant
approved these changes
Oct 16, 2024
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
…ashwin/sse Add support for SSE transport
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
e665be0 Merge pull request modelcontextprotocol#14 from modelcontextprotocol/justin/fix-race-condition be9c1fe Merge branch 'main' into justin/fix-race-condition 36ba802 Merge pull request modelcontextprotocol#17 from modelcontextprotocol/ashwin/capabilities a1b8886 yarn build 7b718de Report errors when start() is called multiple times 83a43fd Protocol.connect() can automatically call Transport.start() 8d80cc5 Merge branch 'main' into justin/fix-race-condition bcb4b21 add server capabilities derivation e9c64fb Update tests and CLI 2b0599e Update server SSE transport c39f808 Update client transports 87ae7ff Add start() to Transport interface git-subtree-dir: packages/mcp-typescript git-subtree-split: e665be0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes on a
Transport.start()method, whichClientandServerclasses now call automatically. This fixes a race condition between starting the transport (which causes data to start flowing) and being ready to process messages in the client or server.Calling code should no longer call
Transport.start()unless doing low-level things like proxying.Resolves #2.
To do
await client.connect()is gonna work