Implement protocol-level sessions for TypeScript SDK #888
+547
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SessionId type and schema - Add session interfaces (SessionState, SessionOptions) - Add session state to Protocol class - Add session validation and lifecycle methods - Include sessionId in all outgoing JSON-RPC messages - Add InvalidSession error code and handling - Add comprehensive tests for session validation and lifecycle
- Fix session validation to handle all session/sessionless combinations - Update capturedTransport pattern to capture session state - Include sessionId in all response messages using captured state - Update RequestHandlerExtra sessionId type to support SessionId - Remove unused imports from tests Phase 1 complete: Protocol class has full session support
- Simplify server session tests to avoid complex internal mocking - Test session configuration and transport access functionality - Verify session terminate handler registration without method not found error - All session tests now pass (13/13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements protocol-level session support for modelcontextprotocol/modelcontextprotocol#1359
Completed Phases:
Remaining Phases:
Current state: Core session functionality working, all tests passing (13/13)