Skip to content

Fix bug for less data then grad acc #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug for less data then grad acc #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion swift/trainers/trainers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ def __next__(self):
if not use_torchacc():
origin_loader = super().get_train_dataloader()
grad_acc_steps = self.args.gradient_accumulation_steps
if grad_acc_steps is None or grad_acc_steps <= 1:
if grad_acc_steps is None or grad_acc_steps <= 1 or len(
origin_loader) < grad_acc_steps:
return origin_loader

length = len(origin_loader) // grad_acc_steps * grad_acc_steps
Expand Down