feat: add publicPath option #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gioboa
reviewed
Aug 25, 2025
- Add publicPath option to ModuleFederationOptions interface - Implement resolvePublicPath utility for consistent path resolution - Support explicit publicPath override, Vite base, and 'auto' fallback - Integrate with pluginMFManifest and pluginProxyRemoteEntry
pcfreak30
force-pushed
the
fix/public-path
branch
from
6833b26 to
d4df41f
Compare
|
@gioboa this is ready. fixed the e2e tests. |
gioboa
approved these changes
Sep 3, 2025
Can you please clarify? |
gioboa
reviewed
Sep 3, 2025
since GitHub borked the comments, ill repeat: Can you please clarify? |
gioboa
reviewed
Sep 3, 2025
No. I never made an issue for this. This was unique to my situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an edge case use case where I need to have an empty base path for localhost development which would trigger the
automode in the federation path lookup. However this causes a problem with vites base which if empty creases the html assets at./not/which breaks my app.So I need the ability to override and separate them, keeping MF publicPath auto, but changing the vite base for the HTML.