TSL: Refine pow2/3/4
implementation and remove the polyfill for pow
on Windows
#31720
+5
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31712
Description
This PR changes the implementation of
pow2
,pow3
, andpow4
to be exact powers of 2, 3, and 4 respectively, regardless of the host implementation ofpow
.Additionally, it removes the polyfill for
pow
on Windows, because it is only valid for odd integer exponents, as explained in the aforementioned issue. This does make the behavior ofpow
with odd integer exponents unstable on Windows, but it is a reasonable behavior and cannot be avoided unless introducing a precise detection of integer exponents in floating-point numbers.