-
Notifications
You must be signed in to change notification settings - Fork 41.9k
fix(core): Fix pagination in body when parameter is inside an Array #18568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(core): Fix pagination in body when parameter is inside an Array #18568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 2 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
packages/core/src/execution-engine/node-execution-context/utils/request-helper-functions.ts
Show resolved
Hide resolved
...src/execution-engine/node-execution-context/utils/__tests__/request-helper-functions.test.ts
Show resolved
Hide resolved
packages/core/src/execution-engine/node-execution-context/utils/request-helper-functions.ts
Outdated
Show resolved
Hide resolved
Hey @paivaric, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: Regarding new nodes: If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach. About review timelines: Thank you again for contributing to n8n. |
Summary
When the body pagination parameter is inside an array, the pagination doesn't work.
Related Linear tickets, Github issues, and Community forum posts
#18567
fixex #18567
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)