Adds verifyNep413Message to _____ package [don't merge] #1605
Conversation
|
| @@ -0,0 +1,68 @@ | |||
| import { | |||
| SignedMessage, | |||
There was a problem hiding this comment.
I need this to be a shared type, could put it in types
SignedMessage + Nep413Message or just Message
There was a problem hiding this comment.
+1 for putting shared types on the types package
| throw new Error( | ||
| `Cryptographic signature verification failed: ${error instanceof Error ? error.message : String(error) | ||
| }`, | ||
| ); |
There was a problem hiding this comment.
near-sign-verify throws on failed verify, I think we should do this here too rather than returning a boolean because it forces the developer to handle it
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
Moved over some things, started an example, started putting it in utils but I don't think it should go here in order to avoid circular dependencies and to utilize some shared types w/ existing signNep413Message.
I'm thinking of moving it to a verify.ts in
signer, or maybe tocrypto-- but creating a new@near-js/messagespackage sounds pretty clean and would followtransactionspattern.Test Plan
I'll write some tests and an example.
Related issues/PRs
This was requested to accompany
signNep413Message. I'm pulling logic from https://github.com/elliotBraem/near-sign-verify