Skip to content

Improve packstream Structure class #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

Improve packstream Structure class #1232

wants to merge 1 commit into from

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Aug 21, 2025 •
edited
Loading

These changes have no affect on the driver's public API. They're targeted at improving the development and debugging experience.

  • Adjust repr to follow Python's recommendations
  • Fix __eq__ returning NotImplementedError instead of NotImplemented
  • Add type hints
  • Add tests

@robsdedude robsdedude force-pushed the feat/improve-packstream-structure-class branch from d4852e4 to a4e838e Compare August 21, 2025 11:43
@robsdedude robsdedude mentioned this pull request Aug 21, 2025
Open
@robsdedude
Improve packstream Structure class
57472bb 
These changes have no affect on the driver's public API. They're targeted at
improving the development and debugging experience.

 * Adjust `repr` to follow Python's recommendations
 * Fix `__eq__` returning `NotImplementedError` instead of `NotImplemented`
 * Add type hints
 * Add tests
@robsdedude robsdedude force-pushed the feat/improve-packstream-structure-class branch from a4e838e to 57472bb Compare August 21, 2025 15:35
@robsdedude robsdedude marked this pull request as ready for review August 22, 2025 13:12
MaxAake
MaxAake approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅
❓ What is the rules for including changes in the changelog in the python driver? I'm not sure if the lack of a changelog update here is an oversight or deliberate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAake MaxAake MaxAake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @MaxAake