Skip to content

Ensure json files are read and writen in utf-8 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Ensure json files are read and writen in utf-8 #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transform/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def writeAddons(addonDir: str, addons: WriteableAddons, supportedLanguages: Set[
for addonName in addons[nvdaAPIVersion][channel]:
addon = addons[nvdaAPIVersion][channel][addonName]
addonWritePath = f"{addonDir}/en/{str(nvdaAPIVersion)}/{addonName}"
with open(addon.pathToData, "r") as oldAddonFile:
with open(addon.pathToData, "r", encoding="utf-8") as oldAddonFile:
addonData: Dict = json.load(oldAddonFile)
if "translations" in addonData:
del addonData["translations"]
Expand Down Expand Up @@ -163,7 +163,7 @@ def readAddons(addonDir: str) -> Iterable[Addon]:
Skips addons and logs errors if the naming schema or json schema do not match what is expected.
"""
for fileName in glob.glob(f"{addonDir}/**/*.json"):
with open(fileName, "r") as addonFile:
with open(fileName, "r", encoding="utf-8") as addonFile:
addonData = json.load(addonFile)
try:
validateJson(addonData, JSONSchemaPaths.ADDON_DATA)
Expand Down
Loading