Skip to content

feat: Uniform way of closing popup window #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Draft

feat: Uniform way of closing popup window #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lua/neo-tree/ui/popups.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,12 @@ M.alert = function(title, message, size)

local success, msg = pcall(vim.api.nvim_buf_set_lines, win.bufnr, 0, 0, false, lines)
if success then
win:map("n", "<esc>", function(bufnr)
win:unmount()
end, { noremap = true })

win:map("n", "<enter>", function(bufnr)
win:unmount()
end, { noremap = true })
local exit_keys = { "<esc>", "<enter>", "q" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable. The only issue is that now the message on line 92 is out of sync with the mappings.

for _, key in ipairs(exit_keys) do
win:map("n", key, function(bufnr)
win:unmount()
end, { noremap = true })
end

local event = require("nui.utils.autocmd").event
win:on({ event.BufLeave, event.BufDelete }, function()
Expand Down