Add C11 atomic wrapper structs to prevent direct access and control memory ordering #13373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a C11 atomic wrapper system that prevents direct access to atomic variables and provides explicit memory ordering control, addressing the overhead of sequential consistency.
Problem
OpenMPI currently uses C11
_Atomic
types directly via typedefs, which allows users to accidentally perform direct assignments that default to sequential consistency:Solution
The implementation wraps all
_Atomic
types in structs to prevent direct access and provides accessor functions with explicit memory ordering control:Key Changes
_Atomic
types are now wrapped in structs with.value
membersmemory_order_relaxed
to avoid seq_cst overheadAffected Components
opal_stdatomic.h
,atomic_stdc.h
)Verification
The wrapper successfully prevents compilation of direct atomic access:
This ensures all atomic operations use explicit memory ordering, eliminating accidental sequential consistency overhead while maintaining correctness.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.