8365765: thread.inline.hpp includes the wrong primary header file

[Arraying]

Hi all,

This ensures thread.inline.hpp adheres to the style guide:

All .inline.hpp files should include their corresponding .hpp file as the first include line with a blank line separating it from the rest of the include lines. [...]

I've run tests with JDK tiers 1-3 on macOS (AArch64, x64), Linux (AArch64, x64), and Windows (x64); all green.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365765: thread.inline.hpp includes the wrong primary header file (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26896/head:pull/26896
$ git checkout pull/26896

Update a local copy of the PR:
$ git checkout pull/26896
$ git pull https://git.openjdk.org/jdk.git pull/26896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26896

View PR using the GUI difftool:
$ git pr show -t 26896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26896.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Arraying! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365765: thread.inline.hpp includes the wrong primary header file

Reviewed-by: stefank, ayang, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• f5f414f: 8365186: Reduce size of j.t.f.DateTimePrintContext::adjust
• e1c58f8: 8360540: nmethod entry barriers of new nmethods should be disarmed
• f0498c2: 8364764: java/nio/channels/vthread/BlockingChannelOps.java subtests timed out
• ... and 34 more: https://git.openjdk.org/jdk/compare/908f3c96978bfa031414e576f444ec8f4dcc6925...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @albertnetymk, @TheShermanTanker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@Arraying The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6f671c61)
• 00: Full (246d02ef)

[stefank]

Thanks for cleaning this up!

I've left a nit that I'd like to get fixed.

Given that this PR changes the include headers it would be prudent to explicitly test building with precompiled headers disabled (Configure flag --disable-precompiled-headers) in addition to running tier1 testing.

[stefank]

Looks good!

[Arraying]

@stefank thanks for the review! FYI, tier1 without precompiled headers has just passed on macOS, Linux and Windows.