8365976: G1: Full gc should mark nmethods on stack

[tschatzl]

Hi all,

please review this fix that moves the nmethod arming after registering the nmethods during full gc to make sure that the remaining ones are armed. That changed after JDK-8360540.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365976: G1: Full gc should mark nmethods on stack (Bug - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26899/head:pull/26899
$ git checkout pull/26899

Update a local copy of the PR:
$ git checkout pull/26899
$ git pull https://git.openjdk.org/jdk.git pull/26899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26899

View PR using the GUI difftool:
$ git pr show -t 26899

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26899.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365976: G1: Full gc should mark nmethods on stack

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (38adef08)