8362573: Incorrect weight of the first ObjectAllocationSample JFR event (regression) #26900
+164
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
Fix to ensure that the ObjectAllocationSample event sample weight property is initialized correctly when the event is enabled.
The previous clearing logic has been integrated into the existing thread iteration as part of the notify process, to avoid double passes. In addition, clearing and the event only apply to the set of JavaThreads.
This time also includes a regression test.
Testing: jdk_jfr
Thanks
Markus
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26900/head:pull/26900
$ git checkout pull/26900
Update a local copy of the PR:
$ git checkout pull/26900
$ git pull https://git.openjdk.org/jdk.git pull/26900/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26900
View PR using the GUI difftool:
$ git pr show -t 26900
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26900.diff
Using Webrev
Link to Webrev Comment